thank you angga888~angga888 wrote:I think you should change this:into:Code: Select all
for( i = 0 ; prime[i]*prime[i] <= x ; i++ ) { ... }
that is possibly your mistakeCode: Select all
for( i = 0 ; i < Cprime && prime[i]*prime[i] <= x ; i++ ) { ... }
mohiul alam prince wrote:Hi
you have generated prime up to 46337 and your prime counter value
Cprime is 4791
when the input is 2147483647 and prime = 46337 and i = 4791
at that time your this condition prime * prime <= x will satisfied
but when you increase i at that time prime[4792] will contain a garbage value because you have generated 4791 prime's
suppose the garbage value prime[4792] = 1 and the input
is 2147483647
then this is fall into a infinite loop and it always print 1.
That's why you have got OLE.
Thanks
MAP
Code: Select all
program faktorprime583;
var n,i,l,s:longint;
begin
readln(n);
while n<>0 do begin
write(n,' = ');
if (n<0) and (n<>-1) then
write(-1,' x ');
if n=-1 then
begin
writeln(n);
readln(n);
continue;
end;
n:=abs(n);
if n=1 then
begin
writeln(n);
readln(n);
continue;
end;
l:=round(sqrt(n))+1;
repeat
if n mod 2=0 then
begin
write(2);
n:=n div 2;
if n<>1 then write(' x ');
end;
until (n mod 2<>0);
i:=3;
repeat
if ((n mod i)=0) then
begin
write(i);
n:=n div i;
if n<>1 then write(' x ');
end
else
inc(i,2);
until
(i>=l) or (n=1);
if n>1 then write(n);
writeln;
readln(n);
end;
end.
Code: Select all
program faktorprime583;
var n,i,l,s:longint;
begin
readln(n);
while n<>0 do begin
write(n,' = ');
if (n<0) and (n<>-1) then
write(-1,' x ');
if n=-1 then
begin
writeln(n);
readln(n);
continue;
end;
n:=abs(n);
if n=1 then
begin
writeln(n);
readln(n);
continue;
end;
l:=round(sqrt(n))+1;
repeat
if n mod 2=0 then
begin
write(2);
n:=n shr 1;
if n<>1 then write(' x ');
end;
until (n mod 2<>0);
if n>1 then
repeat
if n mod 3=0 then
begin
write(3);
n:=n div 3;
if n<>1 then write(' x ');
end;
until (n mod 3<>0);
if n>1 then
i:=6;
begin
repeat
while ((n mod (i-1))=0) do
begin
write(i-1);
n:=n div (i-1);
if n<>1 then write(' x ');
end;
while ((n mod (i+1))=0) do
begin
write(i+1);
n:=n div (i+1);
if n<>1 then write(' x ');
end;
inc(i,6);
until
((i-1)>l) or (n=1);
if n>1 then write(n);
end;
writeln;
readln(n);
end;
end.
Code: Select all
#include <stdio.h>
#include <math.h>
int isPrime(int num)
{
int j;
for (j = 2 ;j<num ;j++ )
{
if (num%j == 0)
return 0;
if (j>sqrt(num))
{
return 1;
}
}
return 0;
}
void primeFact(int x)
{
int result [100];
int i;
int j = 0;
int temp = x;
printf("a");
if (x<0)
{
result[j++] = -1;
x *= -1;
}
for (int i = 2 ;i<=x ;i++ )
{
if (x%i == 0 && isPrime(i))
{
while (x%i == 0)
{
result[j++] = i;
x /= i;
}
}
}
result[j] = '\0';
printf("%d = %d",temp, result[0]);
for (i = 1; result[i]!='\0'; i++)
{
printf(" x %d", result[i]);
}
printf("\n");
}
int main(int argc, char *argv[])
{
int x;
while (scanf("%d", &x)!= 0)
{
if (x==0)
break;
primeFact(x);
}
return 0;
}
Code: Select all
cprime = 0;
prime[cprime ++] = 2;
/*
GENERATING PRIMES UPTO 46342
*/
for (k=3; k<=46342; k+=2)
{
for (i=0; prime[i]*prime[i] < k; i++)
{
if (k % prime[i] == 0)
break;
}
if (prime[i]*prime[i] > k)
{
prime[cprime++] = k;
}
}
/*
long long prime[4800]; this array is for precalculated primes,
BE SURE, there are less than 4800 in the
range :)
long long i, k, cprime; these are indices
*/
Code: Select all
#include<stdio.h>
#include<math.h>
#define MAX 5000
#define P 46401
long factor[MAX];
long prime[P];
long p[MAX];
void main()
{
long n,count,i;
long j;
/*freopen("in.txt","r",stdin);*/
prime[0]=prime[1]=1;
for(i=2; i<=(long)sqrt(P-1); i++)
{
if(prime[i]==0)
{
for(j=i*i; j<=P-1; j=j+i)
{
prime[j]=1;
}
}
}
j=0;
for(i=0; i<=P-1; i++)
{
if(prime[i]==0) p[j++]=i;
}
while(scanf("%ld",&n)!=EOF)
{
if(n==0) break;
printf("%ld = ",n);
if(n<0)
{
printf("-1 x ");
n=-n;
}
count=0;
for(i=0; p[i]<=(long)sqrt(n); i++)
{
while(n%p[i]==0)
{
n=n/p[i];
factor[count]=p[i];
count++;
}
}
if(n!=1) factor[count++]=n;
for(i=0; i<count; i++)
{
printf("%ld",factor[i]);
if(i!=count-1)printf(" x ");
}
printf("\n");
}
}