483 - Word Scramble

[terry646623]

Why am I get output limit? Please help

Code: Select all

Got accepted when using while( get(letter) ) {...}

Thank You!

[brianfry713]

don't use system("pause");
EOF will never equal 1. You could instead do something like while(gets(letter)) {

[rajib2k10]

It is printing a space before start of each output.

Code: Select all

#include <algorithm>
#include <bitset>
#include <cstring>
#include <cctype>
#include <cmath>
#include <iostream>
#include <list>
#include <map>
#include <queue>
#include <string>
#include <set>
#include <stack>
#include <stdio.h>
#include <sstream>
#include <utility>
#include <vector>
#define INT_MAX 2147483647
#define INT_MIN -2147483648
#define pi acos(-1.0)
#define N 1000000
#define LL long long

using namespace std;

int main()
{
    string input;
    char names[100];
    while(getline(cin,input))
    {
        istringstream iss(input);
        while(iss>>names)
        {
            int len = strlen(names);
            for(int i=len;i>=0;i--)
            {
                if(names[i] == ' ')
                {
                    continue;
                }
                cout<<names[i];
            }
        }
        cout<<"\n";
    }
return 0;
}

[brianfry713]

You're printing a null char at the end of each line.

[rajib2k10]

Actually, I didn't get it. I didn't use a cout to print a null character. so please can you tell me where is the bug. if you can then please tell me what should i do to not print a null character so that i can learn that error. Thanks

[brianfry713]

There is a null char at the end of each string. strlen returns the index to that null char and that is the first thing you're printing.

[Shadow_Coder]

Hello. I'm trying to solve the 483 Word Scramble problem, but I'm getting WA. When I run the code on my computer with the given test data, the result comes alright. But, it still gets a WA. Below given is my code. Can anybody help me?

Code: Select all

#include <sstream>
#include <string>
#include <iostream>
using namespace std;

string strrev(string s){
    string t(s.rbegin(), s.rend());
    return t;
}

int main() {
	string s, t;
	while(!cin.eof()){
		getline(cin, s);
		istringstream buffer(s);
		while(buffer >> t){
			cout << strrev(t) << " ";
		}
		cout << "\n";
	}
	return 0;
}

[brianfry713]

Don't print a space at the end of a line.

[Shadow_Coder]

Thanks, got AC! I had to prevent the newline and the space at the end of the last line. Below is the code.

Code: Select all

#include <sstream>
#include <string>
#include <iostream>
using namespace std;

string strrev(string s){
    string t(s.rbegin(), s.rend());
    return t;
}

int main() {
   string s, t;
   while(!cin.eof()){
      getline(cin, s);
      istringstream buffer(s);
      while(buffer >> t){
         cout << strrev(t);
         if(!buffer.eof()) { cout << " "; }
      }
      if(!cin.eof()) cout << "\n";
   }
   return 0;
}

[shaficse]

I am getting presentation error .
Please someone help me?

#include <iostream>
#include <cstdio>
#include <cstring>


using namespace std;
void reverse_string(char* pch)
{
int len=strlen(pch);
char temp;
for(int i=0;i<len/2;i++)
{
temp=pch;
pch=pch[len-i-1];
pch[len-i-1]=temp;
}
printf("%s ",pch);
}


int main()
{

char str[10000];
while(gets(str))
{
char *pch;
pch=strtok(str," ");
while(pch!=NULL)
{
reverse_string(pch);
pch=strtok(NULL," ");
}
printf("\n");
}

return 0;
}

[lighted]

You are printing extra space at the end of line. You can make following changes

Code: Select all

printf("%s ",pch);

It must be

Code: Select all

printf("%s",pch);

Add one line

Code: Select all

while(pch!=NULL)
{
    reverse_string(pch);
    pch=strtok(NULL," ");
    if (pch != NULL) putchar(' ');
}

Don't forget to remove your code after getting accepted.

By the way,

Code: Select all

use code tags

[shaficse]

thank you lighted . i can not do this type of error again.

[moxlotus]

The following code executes perfectly fine on my machine but gets RE on UVa.

Code: Select all

 AC

Can someone tell me where the source of RE is in this piece of code? perhaps a test case that can cause RE will be much appreciated.

[lighted]

Increase value of size by 1 for '\0' character.

[moxlotus]

Increase value of size by 1 for '\0' character.

Thanks.