10494 - If We Were a Child Again

[Laevatein]

can anyone help me? i don't have any idea why my code is wrong

Code: Select all

#include <cstdio>
#include <iostream>
#include <string>
using namespace std;

string bagi(string a, long long b)
{
	long long nilai = 0;
	string  hasil;
	bool belum = true;
	for (long i = 0; i < a.length(); i++)
	{
		nilai *= 10;
		nilai += a[i]-'0';
		if (belum)
		{
			if (nilai/b)
			{
				belum = false;
				hasil.push_back(('0' + nilai/b));	
			}
		}	
		else
			hasil.push_back(('0' + nilai/b));
		nilai %= b;	
	}
	if (belum) return "0";
	return hasil;
}

long long mod(string a, long long b)
{
	long long nilai = 0;
	bool belum = true;
	for (long i = 0; i < a.length(); i++)
	{
		nilai *= 10;
		nilai += a[i]-'0';
		nilai %= b;
	}
	return nilai;
}

int main()
{
	long long b;
	string a;
	char c;
	bool sudah = false;
	while (cin >> a)
	{
		if(sudah) printf("\n");
		else sudah = true;
		scanf(" %c %lld",&c,&b);
		if (c == '/')
			cout << bagi(a,b);
		else
			cout << mod(a,b);
		
	}
	return 0;	
}

[brianfry713]

Print a newline at the end of the last line.

[hello]

Code: Select all

#include<stdio.h>
#include <iostream>
#include<algorithm>
#include<math.h>
#include<stdlib.h>
#include<string>
#include<vector>
#include<string.h>


using namespace std;

int main()
{

   char ch;
   unsigned long int rem;
   char str1[1000];
   unsigned long int num;
   while(scanf("%s %c %lu",str1,&ch,&num)==3){
    if(ch=='%'){
             rem=0;
            for(int i=0;str1[i];i++){
                rem=rem*10+(str1[i]-'0');
                     rem=rem%num;
                }
                printf("%d\n",rem);
            }
    if(ch=='/'){
            rem=0;
            int flag=0;
    int dev;
        for(int i=0;str1[i];i++)
                  {
                    rem=rem*10+(str1[i]-48);
                    dev=rem/num;
                    if(flag==0 && dev>0)flag=1;
                    if(flag==1)printf("%d",dev);
                    rem=rem%num;
                  }
                  printf("\n");


    }

    }
return 0;


   }

got a WA why.......?

[brianfry713]

Input:

Code: Select all

99999999999999999999999999999999999999999999999999999999999999999999999999999 % 2147483647
99999999999999999999999999999999999999999999999999999999999999999999999999999 / 2147483647

Correct output:

Code: Select all

450864903
46566128752457969241057508271679984532147638747537340385623900399368

[uDebug]

Input: Correct output:

Thanks for sharing this test case.

[Shahidul.CSE]

Code: Select all

Removed after getting AC

[lighted]

Value of r is overflowing long type.

Code: Select all

 r = r * 10 + n[i] - '0';
 res[i] = r / d + '0';
 r = r % d;

When d = 2147483647. After r = r % d opeation r can get value between 214748364..2147483646 and in the next iteration of for loop r = r * 10 + n - '0' value of r will be greater than 2147483647.
So use long long for r.

[Shahidul.CSE]

Removed after getting AC

[lighted]

I don't know what the problem is but changing printing to puts gives acc.

Code: Select all

if(sign=='/')
{
    puts(result);           
}

[ehsanulbigboss]

GOT AC!

[brianfry713]

Next time post in the existing thread.
Don't make a function return a pointer to a local variable. In g++ that gives me a warning. Either print ans in your division function or make ans global.